Talk:Quick Edit
Add topicEditing non-existent pages
[edit]@Iniquity: QuickEdit works very well with edittop, except for pages that don't exist, at which it would throw API errors. Could it be improved to fall back gracefully on such pages? NguoiDungKhongDinhDanh 04:38, 17 September 2025 (UTC)
- Also, occasionally QuickEdit would show one-line editors (that is, vertically narrow editors) when the section is (almost) empty. I think the minimum number of visible lines should be, say, 5 instead of 1. NguoiDungKhongDinhDanh 05:25, 17 September 2025 (UTC)
- I think I fixed this about two weeks ago :) Iniquity (talk) 04:12, 18 September 2025 (UTC)
- Can you please show some examples :) Iniquity (talk) 04:12, 18 September 2025 (UTC)
- @Iniquity: Sure. An example of a non-existent page would be MediaWiki:Group-sysop, and an example of a page that has an empty lead section would be c:File:Gaztelugache, Bermeo, País Vasco, España, 2019-08-13, DD 14.jpg. NguoiDungKhongDinhDanh 04:23, 18 September 2025 (UTC)
- and an example of a page that has an empty lead section would be c:File:Gaztelugache, Bermeo, País Vasco, España, 2019-08-13, DD 14.jpg.
Hi! I added scrolling to the form so it's immediately visible.
An example of a non-existent page would be MediaWiki:Group-sysop,
But here I don't quite understand what the problem is. Can you explain more? Iniquity (talk) 18:11, 21 September 2025 (UTC)- @Iniquity: Sorry, that was a bad example and bad description on my part. Let me try again:
- Have my fork of edittop and QuickEdit enabled, in that order.
- Go to Quick Edit/Foo.
- Click the quick edit link next to the page's title.
- The console would then show:
TypeError: Cannot read properties of undefined (reading '0')
- NguoiDungKhongDinhDanh 20:18, 21 September 2025 (UTC)
- I think fixed :) Iniquity (talk) 21:35, 21 September 2025 (UTC)
- @Iniquity: Thanks! One last thing: Please change
mediawiki.orgtowww.mediawiki.org. NguoiDungKhongDinhDanh 21:56, 21 September 2025 (UTC)- Done :) Iniquity (talk) 22:06, 21 September 2025 (UTC)
- @Iniquity: Thanks! One last thing: Please change
- I think fixed :) Iniquity (talk) 21:35, 21 September 2025 (UTC)
- @Iniquity: Sorry, that was a bad example and bad description on my part. Let me try again:
- and an example of a page that has an empty lead section would be c:File:Gaztelugache, Bermeo, País Vasco, España, 2019-08-13, DD 14.jpg.
- @Iniquity: Sure. An example of a non-existent page would be MediaWiki:Group-sysop, and an example of a page that has an empty lead section would be c:File:Gaztelugache, Bermeo, País Vasco, España, 2019-08-13, DD 14.jpg. NguoiDungKhongDinhDanh 04:23, 18 September 2025 (UTC)
Avoid adding trailing newline
[edit]@Iniquity: See this diff for an example (the opening <translate> is supposed to be placed on the line right before the heading). MediaWiki seems to add a trailing newline by default. I don't know if there's an elegant fix, but I'm reporting it for the record. NguoiDungKhongDinhDanh 19:43, 23 October 2025 (UTC)
- Yes, I saw that, thanks, I don't understand how to solve it yet :( Iniquity (talk) 15:10, 13 February 2026 (UTC)
Wikivoyage
[edit]@Iniquity: Hi. I noticed that this script doesn't work on Wikivoyage with Minerva skin (nothing happened when clicking on quick edit button). Can this be fixed? Nvdtn19 (talk) 21:20, 26 October 2025 (UTC)
- @Nvdtn19, Hi! I'll take a look in a few days :) Iniquity (talk) 23:28, 3 November 2025 (UTC)
- @Iniquity: Hi.
Wikivoyage now works,but I just rechecked and it seems Wiktionary also having this bug. Can you take a look at it? Nvdtn19 (talk) 07:21, 12 November 2025 (UTC) - Edit: I'm wrong. It doesn't works in Wikivoyage. Nvdtn19 (talk) 02:08, 14 November 2025 (UTC)
- @Nvdtn19, hi! I see it works :) Iniquity (talk) 15:07, 13 February 2026 (UTC)
- @Iniquity: Hi.
Edit summaries
[edit]@Iniquity: I notice that edit summaries are parsed manually rather than passed to action=parse&summary=<...>. Is that necessary? NguoiDungKhongDinhDanh 09:41, 1 December 2025 (UTC)
- @NguoiDungKhongDinhDanh, I think I need to rewrite this part :) Iniquity (talk) 15:09, 13 February 2026 (UTC)
Edit links
[edit]| It is requested that an edit or modification be made to this protected page. Please remove this template after the request is fulfilled. |
@Iniquity: Please apply the following change to User:Iniquity/quickEdit.js:
| Line 33: | Line 33: |
| $('[href*="section="]', this) | $('[href*="section="]', this) |
| .last() | .last() |
| .after( |
.after($editHereLink.clone(true)) |
| $editHereLink.clone(true)) | |
| .addClass('qe-target'); | .addClass('qe-target'); |
| }); | }); |
Separators are now added using CSS. See phab:T268900 for more information. NguoiDungKhongDinhDanh 21:56, 17 June 2026 (UTC)