r61902 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61901‎ | r61902 | r61903 >
Date:04:13, 3 February 2010
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Fix bug where link to the wrong page was displayed in thread-moved breadcrumb
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/View.php
——@@ -1181,8 +1181,7 @@
11821182 $author = $thread->author();
11831183 $sig = $sk->userLink( $author->getID(), $author->getName() ) .
11841184 $sk->userToolLinks( $author->getID(), $author->getName() );
1185 - // FIXME: this is a link to the old talk page, not the new one.
1186 - $newTalkpage = $thread->article()->getTitle();
 1185+ $newTalkpage = $t_thread->article()->getTitle();
11871186
11881187 $html = wfMsgExt( 'lqt_move_placeholder',
11891188 array( 'parseinline', 'replaceafter' ),

Comments

#Comment by Siebrand (talk | contribs)   15:40, 25 February 2010

Reporting this here, because I'm getting an issue on this line (running r62948):

http://translatewiki.net/wiki/Support uses and the page no longer loads with error:

PHP Fatal error: Call to a member function article() on a non-object in classes/View.php on line 1498

#Comment by Siebrand (talk | contribs)   15:41, 25 February 2010

Parser function was eaten by parser :)

I meant to say:

http://translatewiki.net/wiki/Support uses {{#UseLiquidThreads:1}} and the page no longer loads with error

#Comment by Brion VIBBER (talk | contribs)   03:21, 4 February 2011

This line has been since fixed in r63002: 

		$newTalkpage = is_object( $t_thread ) ? $t_thread->getTitle() : '';

Status & tagging log