Jump to content

Talk:Oauthclient-php

From mediawiki.org
Revision as of 15:00, 17 March 2023 by AManWithNoPlan (talk | contribs) (Minor error messages: New section)

Latest comment: 3 years ago by AManWithNoPlan in topic Minor error messages

The repository URL is rot

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.


The repository URL is rot: https://gerrit.wikimedia.org/r/mediawiki/oauthclient-php.git Valerio Bozzolan (talk) 05:19, 17 September 2020 (UTC)Reply

I've found that it's moved there: https://gerrit.wikimedia.org/g/mediawiki/oauthclient-php Valerio Bozzolan (talk) 05:21, 17 September 2020 (UTC)Reply
The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Minor error messages

These get logged when people use, and are probably not useful.

Undefined property: stdClass::$key in /data/project/citations/public_html/vendor/mediawiki/oauthclient/src/Client.php on line 181

Undefined property: stdClass::$secret in /data/project/citations/public_html/vendor/mediawiki/oauthclient/src/Client.php on line 181

I think that the code should probably handle these cases better.

Probably use "(string) @" in front of them. AManWithNoPlan (talk) 15:00, 17 March 2023 (UTC)Reply