Jump to content

Talk:Oauthclient-php: Difference between revisions

From mediawiki.org
Latest comment: 3 years ago by Tgr (WMF) in topic Minor error messages
Minor error messages: Marked topic as resolved
m Flow talk page manager moved page Talk:Oauthclient-php to Talk:Oauthclient-php/Flow without leaving a redirect: Flow archival
(No difference)

Revision as of 19:51, 17 December 2024

The repository URL is rot

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.


The repository URL is rot: https://gerrit.wikimedia.org/r/mediawiki/oauthclient-php.git Valerio Bozzolan (talk) 05:19, 17 September 2020 (UTC)Reply

I've found that it's moved there: https://gerrit.wikimedia.org/g/mediawiki/oauthclient-php Valerio Bozzolan (talk) 05:21, 17 September 2020 (UTC)Reply
The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Minor error messages

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.


These get logged when people use, and are probably not useful.

Undefined property: stdClass::$key in /data/project/citations/public_html/vendor/mediawiki/oauthclient/src/Client.php on line 181

Undefined property: stdClass::$secret in /data/project/citations/public_html/vendor/mediawiki/oauthclient/src/Client.php on line 181

I think that the code should probably handle these cases better.

Probably use "(string) @" in front of them. AManWithNoPlan (talk) 15:00, 17 March 2023 (UTC)Reply

That means the server failed to return the expected JSON data and the OAuth handshake failed. Some error checking would certainly be nice. Filed as T332429. Tgr (WMF) (talk) 19:00, 17 March 2023 (UTC)Reply
The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.