View source for Talk:Snippets/Direct imagelinks to Commons

== Secure server ==
Is it still necessary to include checks for the secure server? --[[User:Locos epraix|Locos epraix]] ([[User talk:Locos epraix|talk]]) 08:16, 8 March 2012 (UTC)

== MV compatiblity ==

I've suggested here a code improvement[https://de.wikipedia.org/w/index.php?title=MediaWiki:Gadget-Direct-link-to-Commons.js&curid=7012302&diff=132885539&oldid=126461332] ({{Ping|Krinkle}}-) --[[User:Perhelion|Perhelion]] ([[User talk:Perhelion|talk]]) 11:50, 8 August 2014 (UTC)

== User language? ==

I oppose [[Special:Diff/1004563/1098302|this change]] by [[User:He7d3r|He7d3r]], as I've set my language properly on Commons and find the 'uselang' parameter quite annoying. --<span style="font-variant:small-caps">[[User:Ricordisamoa|<span style="color:#004B70">Ricordi</span>]][[User talk:Ricordisamoa|<span style="color:#00703E">samoa</span>]]</span> 23:17, 13 January 2015 (UTC)
:@[[User:Ricordisamoa|Ricordisamoa]]: I was just tying to [[ResourceLoader/Migration guide (users)#Keep gadgets central|keep the gadget code central]], instead of [https://ar.wikisource.org/w/index.php?title=ميدياويكي:Gadget-directLinkToCommons.js&diff=prev&oldid=151747 maintaining each fork] of the code separately (which does not scale!). See also [[Talk:Snippets#Make it possible to import the snippets directly]]. [[User:He7d3r|Helder]] 19:05, 10 July 2015 (UTC)
:{{done|[[Special:Diff/1660995|Reverted]]}} by Krinkle. --<span style="font-variant:small-caps">[[User:Ricordisamoa|<span style="color:#004B70">Ricordi</span>]][[User talk:Ricordisamoa|<span style="color:#00703E">samoa</span>]]</span> 14:11, 28 July 2015 (UTC)

== MMV compatibility II ==

{{ping|He7d3r|Krenair|Jdforrester (WMF)|Krinkle}} MultiMediaViewer is enabled by default. If I enable this gadget on my home wiki, it doesn't work. I have to disable MMV first to make this gadget work. It isn't hard for experienced users, but for beginners it is almost impossible to find out, how to make this gadget work. They just try to enable it to see its effect, they don't see any effect (because of enabled MMV) and they disable it back. Could you somehow force the direct link to Commons over MMV if users enable this gadget (so it is sure thay want to use it)? --[[User:Dvorapa|Dvorapa]] ([[User talk:Dvorapa|talk]]) 19:30, 25 January 2016 (UTC)

:{{reply to|Dvorapa}} I don’t know if anything changed in the pat six years, but now it works as I’d expect it: if I open the link directly in whatever way (opening in new tab, dragging the link to the URL bar etc.), it goes directly to Commons. And so does it if I open MediaViewer and click the big blue button on its toolbar, as MV’s default behavior is to skip the local description page. Just because I never want to see the local description page, I might want to use MediaViewer. Since on most wikis most if not all files are from Commons, MediaViewer would be almost useless if it worked only with local files. —[[User:Tacsipacsi|Tacsipacsi]] ([[User talk:Tacsipacsi|talk]]) 09:17, 5 September 2022 (UTC)

== Broken when the link is different when encoded ==

A user reported this being broken as apparently this now only works when the URL doesn't have characters that needs to be encoded in the URL so I applied [https://fa.wikipedia.org/w/index.php?title=%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Gadget-Direct-link-to-Commons.js&diff=prev&oldid=43450600 this] as attr href is decoded while localBasePath is in encoded space. −[[User:Ebrahim|Ebrahim]]<sup>[[User talk:Ebrahim|talk]]</sup> 08:33, 13 February 2026 (UTC)

== Added compatibility with current MW ==

Hi. It seems like a new version was rolled out and now links start with a local domain (rather than with a path like `/wiki/`). I've replaced it with a fixed version. {{ping|Ebrahim}} I've included your fix too. [[User:Nux|Nux]] ([[User talk:Nux|talk]]) 09:11, 16 April 2026 (UTC)

:@[[User:Krinkle|Krinkle]] please bring back my version. Re-creating vars on each content load is suboptimal. Using regexp is suboptimal. [[User:Nux|Nux]] ([[User talk:Nux|talk]]) 15:07, 16 April 2026 (UTC)
::The final version is at: [[:pl:MediaWiki:Gadget-Direct-link-to-Commons.js]] [[User:Nux|Nux]] ([[User talk:Nux|talk]]) 15:20, 16 April 2026 (UTC)
::@[[User:Nux|Nux]]: Your version introduces bugs due to matching too loosely, sometimes failing to match, or matching too often.
::You can find one of these bugs on [[ru:Катастрофа CRJ-200 под Джефферсон-Сити|Russian Wikipedia]], where it fails to activate due to missing URL encoding.
::On pages like [[pl:Wikipedysta:Theeducatedsparrow]], there is a different bug causing it to be active when it should not, thus breaking the link for a file that is not on Commons (404 Not Found).
::Can you have a look at these? [[User:Krinkle|Krinkle]] ([[User talk:Krinkle|talk]]) 10:54, 17 April 2026 (UTC)
:::Oh yes, I forgot local files are still on the upload domain. And escaping fixed as well. Thanks for the test/review. Should be all good now... unless you see some other problems? [[User:Nux|Nux]] ([[User talk:Nux|talk]]) 19:49, 17 April 2026 (UTC)
:::@[[User:Krinkle|Krinkle]]: Your version is not compatibile with zhwiki.--[[User:Dabao qian|Dabao qian]] ([[User talk:Dabao qian|talk]]) 19:27, 22 August 2026 (UTC)

== Consider a server-side solution ==

This snippet is quite cumbersome, and as the Parsoid adaptation further proved, also somewhat fragile. Doing URL rewrites in client-side JavaScript doesn't feel like the right place for this — it should be handled server-side. Is there an existing Phabricator ticket for this? [[User:Od1n|Od1n]] ([[User talk:Od1n|talk]]) 16:59, 27 June 2026 (UTC)